Open
Conversation
Won’t yet handle multiple expressions.
so we don’t have to deal with multiple return values.
Contributor
Author
|
This is ready for a look @kwmsmith. |
Conflicts: distarray/globalapi/context.py distarray/globalapi/tests/test_context.py
Contributor
|
Closes #301 |
Contributor
There was a problem hiding this comment.
Here and below, looks like some pprints made it through.
Contributor
|
There are 21 skips in the IPython test run -- is that normal? |
Contributor
Author
|
I did add a bunch of MPI-only tests to test lazy-eval... |
Contributor
There was a problem hiding this comment.
So does this allow you to create a context that is always lazy?
Contributor
Author
There was a problem hiding this comment.
Yeah, or at least lazy from the get-go. It really just sets <context>.lazy = True right off the bat. You can still set it to False later if you want.
Contributor
Author
|
Postponing to 0.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #580.
For example:
Our implementation
On the client, when
<context>.lazy == True:<context>._sendq)<context>.sync()is called, the both queues are sent to the engines (one queue per engine actually), and a realrecvis blocked upon.On the engines, when a
'process_message_queue'message is received (containing the queues):sendqis processed, one at a time, and the placeholder values from therecvqare used to feed values forward into the engine-side computationOn the client:
A note on my names
There's a
Contextattribute calledlazy, and aContextmethod calledlazy_eval()that is a context manager (decorated bycontextlib.contextmanager) that sets and unsetslazyunder the hood. If you have better ideas for those names, let me know.Benchmark
I also added a simple benchmark in
examples/lazy_eval. I time a loop that computestanhon a DistArray for a settable number of iterations, both in lazy mode or in the default eager mode. Lazy mode seems to beat eager, but it's not as dramatic as I would have expected. I should probably think through the benchmark more.